SDK-563 make preferUserId configurable#578
Merged
Merged
Conversation
Previously the SDK hardcoded preferUserId: true on users/update, commerce updateCart, and trackPurchase requests, overriding any value the caller passed. Now it uses `payload.preferUserId ?? true` (and `payload.user?.preferUserId ?? true` for the nested commerce user), so callers can opt out while the default stays true.
jena-chakour
changed the title
nunolourenco-itrbl
left a comment
nunolourenco-itrbl
left a comment
Collaborator
There was a problem hiding this comment.
The changes look right. I tested them on react example and I witnessed that:
- not sending preferUserId still defaults to preferUserId: true
- explicitly sending preferUserId as true or false works
joaodordio
changed the title
nunolourenco-itrbl
approved these changes
Jul 16, 2026
nunolourenco-itrbl
left a comment
nunolourenco-itrbl
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to merge!
mprew97
approved these changes
Jul 16, 2026
| ...payload.user, | ||
| preferUserId: true | ||
| /* default to true, but allow the caller to override */ | ||
| preferUserId: payload.user?.preferUserId ?? true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description
Make preferUserId configurable.
Test Steps